[Bug 211718] Review Request: thewidgetfactory - A tool for previewing widgets

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 22 01:19:02 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: thewidgetfactory - A tool for previewing widgets
Alias: thewidgetfactory

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718


peter at thecodergeek.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From peter at thecodergeek.com  2006-10-21 21:18 EST -------
The  %{_bindir} ownership has been fixed; and the .desktop stuff looks good.
Nice work.

The only other issue I can see is that you might want to use the %{name} macro
as part of the Source1 tag instead of hardcoding it, but that's entirely
personal preference as I understand it, and certainly not a blocker.

This package is therefore APPROVED. Go ahead and import it into CVS and request
branches as needed, etc.

Don't forget to close this bug as NEXTRELEASE after you import and build it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list