[Bug 211629] Review Request: hatari - An Atari ST emulator suitable for playing games

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hatari - An Atari ST emulator suitable for playing games


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211629


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776, 177841              |163779
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-10-23 10:47 EST -------
Very good, I was working on a review earlier todat and that was going to contain
a must fix on the hicolor-icon-theme Requires and I didn't even spot the other one.

Anyways here is a full review:

MUST:
=====
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on FC-6 x86_64
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code and permissible (gpl TOS) content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* .desktop file as required and properly installed

Approved!

I'm ready to sponsor you know, please ask Fedora Extras group membership and
I'll sponsor you asap, once thats done you can import this as decribed on the wiki.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.