[Bug 188542] Review Request: hylafax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188542





------- Additional Comments From fedora at christoph-wickert.de  2006-10-24 10:16 EST -------
Sorry it took so lang once again.

There are still some issues with this package that I don't think it makes much
sense to do a review at this point. The main reason is that SRPM and Spec from
comment #29 don't match (see below).

1. debug package is still empty:
$ rpm -qpl hylafax-debuginfo-4.3.0.11-1.fc6.i386.rpm
(contains no files)

Why is there no debug info? If there really is none the debuginfo package should
not be built. Please see
https://www.redhat.com/archives/fedora-packaging/2006-October/msg00149.html
for more info.

2. Changelog is still out of date. Please update the changelog for all releases
and describe the changes you made. This makes it easier for us to track changes.
In order to avoid confusion please increase the release for every new package,
even during the review. 

If we are going to maintain this package together I'd like you to move the
changelog to the end of the spec and insert a blank line between every entry for
legibility. 

3. Ownership of /var/spool/hylafax/bin is still uucp:uucp
$ ls -l /var/spool/hylafax/
...
drwxr-xr-x 2 uucp uucp 4096 21. Okt 00:33 bin
...
This is already fixed in the specfile, but the SRPM is not up to date.

We are reviewing SRPMS, not specs, so I can only do a review if you update your
package and fix these errors.

I still would like root to own more dirs in /var/spool/hylafax, e. g. config and
dev.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.