[Bug 211626] Review Request: xtide - Calculate tide all over the world

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xtide - Calculate tide all over the world


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-26 02:17 EST -------
Well,
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/xtide.spec
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/xtide-2.9-0.10.dev20061015.src.rpm
should fix all the issues that needs fixing. Please check.

(In reply to comment #47)
> Others are ignorable
> W: xtide strange-permission tideEditor-wrapper.sh 0755
> W: xtide dangling-relative-symlink /usr/share/icons/hicolor/48x48/apps/xtide.png
> ../../../../xtide/icon_48x48_orig.png
> W: xtide dangling-relative-symlink /usr/share/icons/hicolor/16x16/apps/xtide.png
> ../../../../xtide/icon_16x16_orig.png
> W: tcd-utils dangling-relative-symlink
> /usr/share/icons/hicolor/16x16/apps/tideEditor.png
> ../../../../xtide/icon_16x16_orig.png
> W: tcd-utils dangling-relative-symlink
> /usr/share/icons/hicolor/48x48/apps/tideEditor.png
> ../../../../xtide/icon_48x48_orig.png
By the way, these warning are avoided once we install this and
execute rpmlint for *INSTALLED* rpm, for example, "rpmlint xtide".

> * spec is not very legible, with tons of macros and building of
>   3-4 different programs with different build systems. 
Well, I leave it for now though this is a bit complicated...

> the guidelines break with desktop-file-utils-0.11-1.fc7.
Maybe desktop-file-utils will change.
 
> - the package which install in hicolor could depend on hicolor-icon-theme
> for directory ownership, but this is not very clear to whether this is
> really right since it adds an otherwise unneeded dependency to a lot 
> of packages.
Well, there is a agreement that hicolor-icon-theme can be treated as
something like "filesystem" rpm. Actually trying to remove
hicolor-icon-theme (by yum) also tries to remove lots of packages
(even gtk2). 

(In reply to comment #48)
> xttpd:
> * initscript should return 2 as "Usage" error return code.
Well, I checked some init scripts in /etc/rc.d/init.d and usually
they return the value 1 so I use 1.

> * With default install, it is very quiet:
> .............................

I hope the updated init script (and wrapper shell script) should
fix this problem.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.