[Bug 211626] Review Request: xtide - Calculate tide all over the world

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xtide - Calculate tide all over the world


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626





------- Additional Comments From pertusus at free.fr  2006-10-26 09:32 EST -------
It works better now, but I am not convinced that it is
the proper fix. I don't see why you need to send the 
echo output on STDERR? It works the same without redirection?
Anyway redirection to log should be done explicitely. So
if you want errors to be logged, I guess you should call
logger yourself.

And also it seems that failure should be used instead of echo_failure
since it does something when with rhgb (show details).
Moreover I think the [ FAILED ] should appear before the explanation.

It leads to the following code:

    if test -z "$PORT" ; then
        failure
        echo
        echo $"PORT environment is not set."
        RETVAL=1
        return $RETVAL

Another remark is that I think having HOME defaulting to /root is wrong,
it should be set to a directory below sysconfig, for example 
%{_sysconfig}/xtide. And I am not completly convinced that using 
nobody as a user is the right thing to do, maybe a specific user
would be better.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.