[Bug 210823] Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210823





------- Additional Comments From bugs.michael at gmx.net  2006-10-26 11:57 EST -------
> $ rpmlint wxsvg-1.0b7-1.src.rpm 
> W: wxsvg summary-not-capitalized wxSVG is C++ library to create,
> manipulate and render SVG files.
> W: wxsvg summary-ended-with-dot wxSVG is C++ library to create,
> manipulate and render SVG files.

Better:

  Summary: C++ library to create, manipulate and render SVG files

Repeating the package name in the summary is often considered bad
style, because it either leads to poor summaries or raises questions
not answered in the summary. For a more detailed description, there
is the package %description field, where you can explain acronyms and
other things, too.

> E: wxsvg no-description-tag

It must not be empty.

> W: wxsvg invalid-license wxWindows Library Licence, Version 3

This needs a second look, since the project is named wxWidgets for
a long time.


Now a brief look at the spec file:

> Version:        1.0b7
> Release:        1%{?dist}

You should take a look at the pre-release versioning scheme, which
makes it possible that you can go from "1.0b7" to "1.0":

  Version:        1.0
  Release:        0.1.b7%{?dist}

> Requires: wxGTK

Not needed and ought to be deleted. Rely on rpmbuild's automatic
dependencies on the library SONAMEs your built files are linked
against.

> %package devel

Missing  "Requires: wxGTK-devel"  since the wxSVG headers include
wxGTK headers.

> Requires: %{name} = %{version}

Ought to be

  Release: %{name} = %{version}-%{release}

so your package-set is always in sync (even if in many cases,
%{version} may be sufficient actually). This strict requirement is
particularly useful when patches are applied. Assume what happens
when the main package is permitted to be older than the -devel package.
The -devel package mentions fixes in its %changelog, but the main
package is not up-to-date and suffers from problems at build-time
or run-time. Or vice versa.


> %build
> ./autogen.sh

Try to get the upstream developers to pregenerate these files, which
is what they ought to do for every release, regardless of whether it's
beta or not. Then you would not be missing automake and friends, which
might be wrong versions.

> %files
> %defattr(-,root,root,-)
> %doc

No %doc files? At least the license file ought to be included.
Possibly also a few of the available text files.

> %files devel
[...]
> %{_includedir}/wxSVG/*.h
> %{_includedir}/wxXML/*.h

The directories are not included. Use either:

  %{_includedir}/wxSVG/
  %{_includedir}/wxXML/

Or:

  %dir %{_includedir}/wxSVG/
  %{_includedir}/wxSVG/*.h
  %dir %{_includedir}/wxXML/
  %{_includedir}/wxXML/*.h

> %{_libdir}/libwxsvg.a
> %{_libdir}/libwxsvg.la

If these cannot be disabled, delete them in %install.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.