[Bug 211807] Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox2 - Mozilla Firefox 2.0 Web browser for FC6


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211807





------- Additional Comments From jima at beer.tclug.org  2006-10-26 16:13 EST -------
I'm not a sponsor, so I can't do an official review, but a couple things jump
out at me:

> 1. find-external-requires is a script

 Does that mean it needs to be transported in the SRPM +x'd?  Can't it be set
644 and chmod'd +x in the conditional that points __find_requires at it?  (I
suspect "yes.")  There's (rarely? never?) a reason to have a file +x in the
SRPM, they can usually be corrected during the prep/build/install process.

> 3. Macro in changelog is an entry from 2003 relating to a valid change.  I 
> don't feel comfortable changing it without clarification

 Neither would I.  However, escaping it as %%attr both preserves the history
(shows up as %attr in --changelog) and shuts rpmlint up about it. ;-)

 Minor tweaks, I wouldn't bother respinning unless you have more important fixes
to add.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.