[Bug 212256] Review Request: echo-icon-thme - Echo icon theme

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: echo-icon-thme - Echo icon theme
Alias: echo

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212256


rstrode at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |188267
              nThis|                            |




------- Additional Comments From rstrode at redhat.com  2006-10-26 16:59 EST -------
It looks pretty good to me.

There isn't much point in including the %build section since it's empty, though,
is there?

In core packages we don't normally add the Requires(pre) and Requires(post) for
gtk2.  instead we only run it gtk-update-icon-cache if it's available.  On the
other hand, since you Require redhat-artwork and it requires gtk2, then I think
the pre and post are right, because you're going to end up with gtk2 installed
anyway, and if that's the case then you want to make sure it gets installed
early enough in the transaction.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.