[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265


jeff at ocjtech.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jeff at ocjtech.us
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jeff at ocjtech.us  2006-10-29 08:47 EST -------
* source files match upstream (can't compare MD5 since this package
  currently uses a CVS snapshot).
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
? can't check it in mock right now because my mock isn't behaving
  properly right now
* package installs properly
* rpmlint comes up empty
! %check is not present; There are some unit tests in
  zope.interface.tests
* no shared libraries, .so file is a Python C module
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers
* unversioned .so file is a Python C module, no -devel package necessary
* no pkgconfig files.
* no libtool .la droppings.

APPROVED, once the %check is added

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.