[Bug 212894] Review Request: libopm - Blitzed open proxy monitor library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libopm - Blitzed open proxy monitor library
Alias: libopm

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212894





------- Additional Comments From chris.stone at gmail.com  2006-10-30 22:02 EST -------
Some initial comments before I can do a formal review:

- Source0 should list the full download URL and use %{name}
- make should use $RPM_OPT_FLAGS
- use %defattr(-,root,root,-)
- You need to mention in a comment how to download the source if there is not a
direct URL
- I think the group should be Development/Libraries for the main package as
well, although I cannot find anything which specifies how the groups are defined
- You should use --disable-static on the %configure
- I think the version number should be done like so:

Version: 0.0.0
Release: 0.2.20050731cvs%{dist}

See
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.