[Bug 203520] Review Request: evolution-brutus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-31 09:39 EST -------
A.
Oh, please don't change the original source tarball without changing
its version!! This will confuse people who use evolution-brutus.

md5sum:
a4ad27d8c158dcea301c23e7e75ebdf0 
evolution-brutus-1.1.7-2/evolution-brutus-1.1.7.tar.gz
aa9d8ae81ae87851b74de0d92fa09ab7 
evolution-brutus-1.1.7-3/evolution-brutus-1.1.7.tar.gz

You should either
* make patches against original 1.1.7.tar.gz tarball or
* release new version of evolution-brutus

B. 
I have not yet rebuilt the new srpm you uploaded, however:
I use rawhide, and Fedora Extras packages have to be rebuilt firstly
for rawhide environment as buildsys forces it.

I have to say that current evolution and evolution-data-server in rawhide is:
[tasaka1 at localhost ~]$ rpm -q evolution evolution-data-server
evolution-2.9.1-2.fc7
evolution-data-server-1.9.1-2.fc7

Please adjust your spec file for these versions.
Through a glance look at your spec,

%dir %{_includedir}/evolution-data-server-1.8/brutus

This is no longer correct as current (current means rawhide)
evolution-data-server has: /usr/include/evolution-data-server-1.10/ .
Please use  %dir %{_includedir}/evolution-data-server-*/brutus to
avoid version changing (also please check if there is some API change or
so).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.