[Bug 187294] Review Request: gwyddion

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwyddion


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187294





------- Additional Comments From pertusus at free.fr  2006-09-07 07:17 EST -------
i am not a sponsor, so I cannot approve the package but I have 
some comments:

gwyddion-devel shouldn't own %{_libdir}/pkgconfig, but instead
Requires: pkgconfig

The shebangs removal seems to be done now, so the following is certainly
not relevant anymore (as said in the comment ;-):
# Remove shbangs from modules (upstream 1.99.8 will fix that)
sed -i '1s/^#!.*//' ruby/gwyddion/dump.rb python/Gwyddion/dump.py

For the desktop file you should have a look at:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

There is something very strange, an include file below %_libdir:
/usr/lib/gwyddion/include/gwyconfig.h
I guess it is there because it is a generated include file so it 
could include some platform-dependant informations... I have seen
that other libraries do the same, so I guess it is ok.

There is a missing Requires on ruby and python in -devel (I would
have guessed that they were autodetected, but that's not
the case???).
However, the plugins should certainly be in a separate subpackage, 
called maybe gwyddion-plugin-examples, together with all the 
internal ruby/perl/python modules. Another benefit of doing
a subpackage is that this subpackage could have only
code in the public domain (as it seems to me, but I haven't checked
everything) and could have a a licence marked as such.

These perl/ruby/python modules should certainly be in a 
platform independent location (I would chose %{pkgdatadir}).

Since the perl module is an internal module, the man page should
certainly not be shipped, and the automatically determined
Provides perl(Gwyddion::dump) should not be present

Removing the provides may be achieved by
%define __perl_provides %{nil}

Wouldn't it be better if the perl/python/ruby modules where real 
modules?

I am not convinced that the -devel package should require the base package,
if plugin examples are removed.
but it should certainly require the libs package, so I propose changing  
Requires:      %{name} = %{version}
to 
Requires:      %{name}-libs = %{version}-%{release}

The %post/%postun should be for the libs subpackage and not the main package.

There are %post scriptlets missing for mime handling, you should have
a look at
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef
and
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-5f93ed83c968bb73b052c06ba0d7139e28f35d93

Otherwise it built and run on a Fc devel i386.

If I'm not wrong you are the upstream for this project,
maybe you could supply an example data file gwyddion can
handle for potential users to test.

Poking around in the source files, I have seen something that looks
like a file for vim, if you feel like it you can make another subpackage
for that file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.