[Bug 197419] Review Request: php-pear-Validate-Finance-CreditCard - PEAR: Validation class for Credit Cards

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Validate-Finance-CreditCard - PEAR: Validation class for Credit Cards
Alias: Validate-Finance-CC

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197419


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-07 22:03 EST -------
* source files match upstream:
   a4eb8f52783b2f15ea99f0210ab1eda8  Validate_Finance_CreditCard-0.5.2.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent (except for the bogus dangerous-command warning)
* final provides and requires are sane:
   php-pear(Validate_Finance_CreditCard) = 0.5.2
   php-pear-Validate-Finance-CreditCard = 0.5.2-1.fc6
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
* %check is not present; not currently possible to run the test suite in an
automated fashion.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (PEAR module installation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.