[Bug 201000] Review Request: libFoundation - A free implementation of OpenStep's Foundation Kit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libFoundation - A free implementation of OpenStep's Foundation Kit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201000





------- Additional Comments From rpm at greysector.net  2006-09-10 15:23 EST -------
Here we go:

1. package meets naming and packaging guidelines.
2. specfile is properly named, is cleanly written and uses macros consistently.
3. dist tag is present.
4. build root is sane, though not the recommended one
5. license field matches the actual license.
6. ??? license is open source-compatible. License text included in package.
7. source files match upstream:
7df921ab5705af28a75e62a3a8744cb6  libFoundation-1.1.3-r155.tar.gz
8. latest version is being packaged.
9. BuildRequires are proper.
10. package builds in mock ( ).
11. rpmlint warnings as expected.
12. final provides and requires are sane:

libFoundation.so.1.1()(64bit)
libFoundation = 1.1.3-8
=
/sbin/ldconfig
libFoundation.so.1.1()(64bit)
libc.so.6()(64bit)
libdl.so.2()(64bit)
libm.so.6()(64bit)
libobjc.so.1()(64bit)

libFoundation-devel = 1.1.3-8
=
gcc-objc
gnustep-make
libFoundation = 1.1.3-8

13. shared libraries are present and ldconfig is called as appropriate
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. duplicates in %files:
warning: File listed twice: /usr/include/Foundation
warning: File listed twice: /usr/include/Foundation/Foundation.h
...
warning: File listed twice: /usr/include/Foundation/UnixSignalHandler.h
warning: File listed twice: /usr/include/Foundation/exceptions
warning: File listed twice:
/usr/include/Foundation/exceptions/EncodingFormatExceptions.h
...
warning: File listed twice: /usr/include/Foundation/exceptions/StringExceptions.h
warning: File listed twice: /usr/include/extensions
warning: File listed twice: /usr/include/extensions/DefaultScannerHandler.h
...
warning: File listed twice: /usr/include/extensions/support.h
warning: File listed twice: /usr/include/lfmemory.h
warning: File listed twice: /usr/include/real_exception_file.h
18. file permissions are appropriate.
19. %clean is present.
20. %check is not present nor necessary
21. no scriptlets present.
22. code, not content.
23. documentation is small, so no -docs subpackage is necessary.
24. %docs are not necessary for the proper functioning of the package.
25. headers in devel
26. no pkgconfig files.
27. no libtool .la droppings.
28. not a GUI app.
29. not a web app.

Please fix 17. Is the license OSI-approved?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.