[Bug 206037] Review Request: php-pear-Console-Table - Class that makes it easy to build console style tables

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 11 18:05:14 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Console-Table - Class that makes it easy to build console style tables
Alias: pear-Console-Table

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206037





------- Additional Comments From chris.stone at gmail.com  2006-09-11 14:05 EST -------
- rpmlint output:
W: php-pear-Console-Table no-documentation
W: php-pear-Console-Table dangerous-command-in-%post install

Both warnings are fine.
- package is named according to Package Naming Guidelines
- spec filename matches package %{name}
- package meets Packaging Guidelines
- package licensed with open source compatible license
- license field in spec matches actual license
- source does not include copy of license
- spec file written in American english
- spec file is l3g1bL3
- sources match upstream
23c6973122c1106673c6ccce7375c4e2  Console_table-1.0.5.tgz
- package successfully compiles and builds on x86_64 FC5
- All build dependecncies are listed in BuildRequires
- package does not use locales
- package does not contain shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicate files in %files
- File permissions are set properly
- package contains proper %clean section
- macro usage is consistent
- package contains permissible code
- no large documentation files
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no .so files
- no devel package
- no .la files
- package is not a GUI needing .desktop files
X Package owns files or directories owned by other packages


==== MUST FIX ====
- Change:

%{pear_phpdir}/Console
 
To:

%{pear_phpdir}/Console/Table.php

The %{pear_phpdir}/Console directory is owned by php-pear.  Packages that fall
under these dirs should not own them.  (NOTE:  I think you need to fix
XML_Parser for this issue as well, sorry I did not spot it earlier).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list