[Bug 192438] Review Request: fedora-xgl-settings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fedora-xgl-settings


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192438





------- Additional Comments From s.adam at diffingo.com  2006-09-18 17:48 EST -------
I've done further testing, and noticed that in your pam files you're using the
old stack - Instead, have the PAM files read:
auth        include     config-util
account     include     config-util
session     include     config-util
Also, building a binary RPM complains about not finding a bunch of javadocs
APIs, and also then fails because it cannot replace a 'overview-frame.html' :
[javadoc] WARNING: Cannot locate class java.nio.CharBuffer referenced in class
org.fedora3ddesktop.cmdline.Utils
[ messages continue ]
[javadoc] WARNING: Cannot locate class org.gnu.gtk.event.ButtonEvent referenced
in class org.fedora3ddesktop.gui.DialogGdmDisplayManager
[ messages continue ]
[...]/BUILD/3ddesktop-0.1/build.xml:86: Replace: source file
[...]/BUILD/3ddesktop-0.1/docs/api/overview-frame.html doesn't existfile.

Maybe there are more %requires needed?

Also, fixing the no-cleaning-of-buildroot error is simple, all you have to to is
add:
rm -rf $RPM_BUILD_ROOT
to the very beginning of %install.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.