[Bug 188400] Review Request: ssmtp

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 21 23:32:16 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ssmtp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188400


s.adam at diffingo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s.adam at diffingo.com




------- Additional Comments From s.adam at diffingo.com  2006-09-21 19:32 EST -------
I'm not a review but I'm waiting on the sponsor of my package so I'll help...

Just so you know your SRPM link gives a 404, it seemed to be moved into a "rpms"
folder.

I ran rpmlint on your SRPM, and it gave only warnings, no errors, which is good
but if you'd like to clear them up anyways, here it is:

W: ssmtp macro-in-%changelog files
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

W: ssmtp macro-in-%changelog postun
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

W: ssmtp macro-in-%changelog buildroot
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

W: ssmtp mixed-use-of-spaces-and-tabs
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list