[Bug 206836] Review Request: TurboJson - Python template plugin that supports json

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TurboJson - Python template plugin that supports json


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206836





------- Additional Comments From s.adam at diffingo.com  2006-09-26 21:54 EST -------
'+' are the good things, '-' are the bad that need fixing:

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- You don't have the COPYING / LICENSE files in your package or in %doc, I'm
pretty sure you need to include those.
- source files match do not upstream: You can no longer download 0.9.9, they're
released 1.0 beta.
- latest version is not being packaged (see above)
+ BuildRequires are proper.
+ rpmlint is silent.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
+ no scriptlets present.
+ code, not content.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.