[Bug 234750] Review Request: avr-binutils - Cross Compiling GNU binutils targeted at avr
bugzilla at redhat.com
bugzilla at redhat.com
Sun Apr 1 17:55:11 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: avr-binutils - Cross Compiling GNU binutils targeted at avr
------- Additional Comments From j.w.r.degoede at hhs.nl 2007-04-01 13:55 EST -------
I have no(In reply to comment #4)
> (In reply to comment #3)
> > This looks good to me. I've gone through the entire Review Guidelines, and
> > cannot find anything that should be a problem. I have tested building the
> > package in mock on both rawhide-i386 and fc6-x86_64, and there were no problems.
> > The complete review report is available in comment #2
> > If there are no other objections I will set the fedora-review flag to +.
> VETO - Allow this package a couple of days for further checking.
> MUSTFIX without having checked details yet.
> * --disable-nls
> nls can't be enabled unless the version is identical to Fedora's.
Actually currently the version is identical to Fedora's (for Fedora 7), but can
you explain this a bit more, what is nls, and what do we loose by disabling it?
Also why must the version be identical to Fedora in order to be able to enable this?
> * --target-prefix
Nope, I thought so too, but %configure does something which makes this necessary
(probably passing -bindir).
Last remark to both you and Trond, what do you think about my initial question:
Notice to reviewers, I've removed the info / manpages and the PO files as these
conflict with the native binutils. I think that this means that this package
should have a "Requires: bintuils" to make sure the native binutils are always
installed, especially for the PO files, I haven't done this yet as I'm not sure,
but I think such a Requires should be added.
So should this require the native binutils for the PO files (which are btw an
other reason to try and keep the native and our version in sync.)
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review