[Bug 234857] Review Request: perl-Geography-Countries - 2-letter, 3-letter, and numerical codes for countries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Geography-Countries - 2-letter, 3-letter, and numerical codes for countries
Alias: Geography-Countries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234857





------- Additional Comments From cweyl at alumni.drew.edu  2007-04-02 13:28 EST -------
+ source files match upstream:
693426ab59ce3d51fcd48dfe3b402107  Geography-Countries-1.4.tar.gz
693426ab59ce3d51fcd48dfe3b402107  ../Geography-Countries-1.4.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
O no debuginfo package -- noarch
+ rpmlint is silent.
+ final provides and requires are sane:
** perl-Geography-Countries-1.4-1.fc6.noarch.rpm
== rpmlint
== provides
perl(Geography::Countries)  
perl-Geography-Countries = 1.4-1.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)  
perl(Exporter)  
perl(constant)  
perl(strict)  
perl(vars) 
+ %check is present and all tests pass
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.