[Bug 223943] Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, debug!

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, debug!
Alias: nemiver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223943





------- Additional Comments From giallu at gmail.com  2007-04-03 06:55 EST -------
Here is the review:

MUST ITEMS:
+ Package name is valid
+ spec file name match base package name
+ spec file is written in American English
+ spec file is legible (very!)

+ Sources matches upstream (289d46e97c125b95fdc5de9dd9736d7c  nemiver-0.3.0.tar.bz2)
+ License is acceptable (GPL)
+ License is included in the package
+ Package builds (in mock) for FC6 i386

+ BuildRequires list looks sane
+ Macros are consistently used
+ Use %find_lang macro for locale files
+ use ldconfig for installed .so files
+ package is not relocatable

+ headers and .so files correctly packaged in -devel
+ -devel correctly Requires base package
+ .la files excluded from package

+ .desktop file present and correctly installed

rpmlint output:

/var/lib/mock/fedora-6-i386-core/result/nemiver-0.3.0-6.fc6.i386.rpm
W: nemiver non-conffile-in-etc /etc/gconf/schemas/nemiver-workbench.schemas
W: nemiver non-conffile-in-etc /etc/gconf/schemas/nemiver-dbgperspective.schemas

This are usually to be ignored (and probably rpmlint should as well...)

/var/lib/mock/fedora-6-i386-core/result/nemiver-0.3.0-6.fc6.src.rpm
W: nemiver mixed-use-of-spaces-and-tabs (spaces: line 167, tab: line 1)

line 167 is in the changelog section, so I think we can ignore this


Just a couple questions: 
is the "touch" trick for forcing the icon cache update the usual/preferred/best
way to do that?
are you going to remove COPYING from the -devel subpackage as suggested in
comment #2?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.