[Bug 225633] Merge Review: bzip2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: bzip2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225633


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

varekova at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?                   |




------- Additional Comments From varekova at redhat.com  2007-04-04 10:34 EST -------
(In reply to comment #22)
> (In reply to comment #18)
> > (In reply to comment #15)
> 
> > > * the original soname don't follow the usual convention of a soname
> > >   number with an integer, but I am not certain that it is right to 
> > >   modify it in fedora. It should better be changed upstream. What is
> > >   the reasoning behind this change?
> > It is the upstream resolution so fedora should accept it 
> 
> But it is not what is done in fedora! the soname is changed in the
> bzip2-1.0.4-saneso.patch patch, and I question that change.
> 
I'm sorry, I have not understand your previous comment so my reply was confused. 
So I'm not sure what are you asking about. 
The version which is in fedora now is right - if there will be any change then
there would be necessary to rebuild all dependencies. I'm not sure why was this
change done (it was about 6 years ago), but it is ok.
This problem should not be a subject of review.
 
> Otherwise
> * there is no need of -p when installing generated binaries, like
>   libbz2.a, bzip2-shared... And the static lib should be 0644. I personally
>   like to have the -mxxx option even when it isn't stricly needed, so
>   what I would have done is:
> 
> install -m644 libbz2.a $RPM_BUILD_ROOT%{_libdir}
> install -m755 libbz2.so.%{version} $RPM_BUILD_ROOT%{_libdir}
> install -m755 bzip2-shared  $RPM_BUILD_ROOT%{_bindir}/bzip2
> install -m755 bzip2recover bzgrep bzdiff bzmore  $RPM_BUILD_ROOT%{_bindir}/
> 
> The only mandatory item here is to have -m644 on the libbz2.a install
> call.
Thanks. Fixed in bzip2-1.0.4-10.fc7.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.