[Bug 234858] Review Request: perl-User-Identity - Maintains info about a physical person

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User-Identity - Maintains info about a physical person
Alias: perl-User-Identity

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234858





------- Additional Comments From cweyl at alumni.drew.edu  2007-04-04 11:19 EST -------
+ source files match upstream:
 d5929be62a99b90f60b07062ab86a2ec  User-Identity-0.91.tar.gz
 d5929be62a99b90f60b07062ab86a2ec  ../User-Identity-0.91.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ no debuginfo package -- noarch
+ rpmlint is silent.
+ final provides and requires are sane:
** perl-User-Identity-0.91-1.fc6.noarch.rpm
== rpmlint
== provides
perl(Mail::Identity) = 0.91
perl(User::Identity) = 0.91
perl(User::Identity::Archive) = 0.91
perl(User::Identity::Archive::Plain) = 0.91
perl(User::Identity::Collection) = 0.91
perl(User::Identity::Collection::Emails) = 0.91
perl(User::Identity::Collection::Locations) = 0.91
perl(User::Identity::Collection::Systems) = 0.91
perl(User::Identity::Collection::Users) = 0.91
perl(User::Identity::Item) = 0.91
perl(User::Identity::Location) = 0.91
perl(User::Identity::System) = 0.91
perl-User-Identity = 0.91-1.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)  
perl(Carp)  
perl(List::Util)  
perl(Mail::Identity)  
perl(Scalar::Util)  
perl(User::Identity)  
perl(User::Identity::Location)  
perl(User::Identity::System)  
perl(base)  
perl(overload)  
perl(strict)  
perl(vars)  
perl(warnings) 
+ %check is present and all tests pass:
All tests successful.
Files=3, Tests=114,  0 wallclock secs ( 0.19 cusr +  0.06 csys =  0.25 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.