[Bug 232160] Review Request: ruby-gnome2 - A ruby binding of libgnome/libgnomeui-2.x

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-gnome2 - A ruby binding of libgnome/libgnomeui-2.x


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232160





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-04 11:50 EST -------
Created an attachment (id=151671)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151671&action=view)
mock build log of ruby-gnome2-0.16.0-2 on FC-devel i386

Well, for -2:
This time mockbuild is no problem on FC-devel i386.

* License
  - Please check license. For me it seems that this package
    is licensed under LGPL.

* Gecko engine dependency
  - Well, for rpath issue, version direction
    is also required for Requires. i.e.
---------------------------------------------
BuildRequires: firefox-devel = 2.0.0.3
Requires:      firefox = 2.0.0.3
---------------------------------------------
    for example.

* Requires
  - Well, check the Requires tree and remove redundant
    Requires.

    EXAMPLE: (this is only a example. please check
    others!!)
    For now ruby-gnome2 has:
---------------------------------------------
Requires:	ruby(glib2) = %{version}-%{release} 
Requires:	ruby(gtk2) = %{version}-%{release}
Requires:	ruby(gnomecanvas2) = %{version}-%{release}
---------------------------------------------
    However, /usr/lib/ruby/site_ruby/1.8/gnome2.rb contains
    only
---------------------------------------------
     1	require 'gnomecanvas2'
     2	require 'gnome2.so'
---------------------------------------------
    for require and thus Requires for ruby(glib2), rubly(gtk2) should
    not be needed
    Perhaps other packages also have to be checked.

    ANOTHER EXAMPLE
    For now ruby-gtk2 contains
---------------------------------------------
BuildRequires: ruby ruby-devel gtk2-devel pango-devel cairo-devel
ruby-cairo-devel
---------------------------------------------
    However
    * ruby-devel should be required by ruby-cairo-devel
    * cairo-devel should be required by ruby-cairo-devel
    * pango-devel is required by gtk2-devel
    So, "ruby-devel pango-devel cairo-devel" is redundant for BuildRequires.

  - And some questionable Requires is found.
    EXAMPLE:
    In ruby-atk-devel, it seems that Requires for ruby-devel is written
    twice.

    (Well, what I wrote is only examples and perhaps some other fixes are
     also needed)

* prep/build stage
---------------------------------------------
ruby extconf.rb
---------------------------------------------
  - IMO this is similar with general configure and
    this should be moved to %build stage.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.