[Bug 235117] Review Request: servletapi4 - Java servlet and JSP implementation classes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: servletapi4 - Java servlet and JSP implementation classes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235117


nsantos at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nsantos at redhat.com          |asimon at redhat.com




------- Additional Comments From nsantos at redhat.com  2007-04-04 11:50 EST -------
> NO * specfile should be %{name}.spec
---> it is named: servletapi4.spec but it should be servletapi4-4.0.4-4jpp.spec

This is OK, %name refers just to the package name. No version/release should be
included in the specfile name.

> ?? * OSI-approved

It's an Apache license, so it's OK.

> ?? * is it covered by patents?

Distributed under Apache license, no explicit references to patents, so to the
best of our knowledge it's OK.

> ?? * verify source and patches (md5sum matches upstream, know what the patches 
> do)

To verify source/patches, follow instructions to obtain source and package it,
then run "md5sum" against the resulting tarfile, and compare to the tarfile
included in the srpm, they should match.
FWIW, md5sum on the tarfile in the srpm is:
91a4aeec8409a427c6a3b6d50924c15d  jakarta-servletapi-4-src.tar.gz

> NO * correct buildroot should be:
>   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
--> it is /jakarta-servletapi-4-src/

This is OK, buildroot in specfile is (see line 54):
BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

> NA * if %{?dist} is used

dist is being used (see line 41):
Release:    %{release}%{?dist}

> NO * license text included in package and marked with %doc
--> included but not marked with %doc:

It's marked with %doc, see line 111:
%doc LICENSE README.txt

> NO * packages meets FHS (http://www.pathname.com/fhs/)
--> The rpm does not contain /lib (not sure this is normal)

It's OK.

> NO * rpmlint on <this package>.srpm gives no output
--> Cannot install source packages.

srpm doesn't need to be installed, just run rpmlint on it directly:
$ rpmlint  servletapi4-4.0.4-1.fc7.src.rpm
W: servletapi4 non-standard-group Internet/WWW/Dynamic Content
W: servletapi4 unversioned-explicit-obsoletes servlet4
W: servletapi4 unversioned-explicit-obsoletes servlet23
W: servletapi4 unversioned-explicit-provides servlet
W: servletapi4 unversioned-explicit-provides servlet4
W: servletapi4 unversioned-explicit-provides servlet23

These warnings are OK (other packages were approved with similar warnings).

> NO * specfile is legible
--> Those fields must be changed
> Name:           %{name}
> Version:        %{version}
> Release:        %{release}.1%{?dist}

Using the macros allows for name/version/release to be referred to later in the
specfile.

> ?? * package successfully compiles and builds on at least x86
> ?? * BuildRequires are proper

You'll have to setup mock and try to build the package there, to verify that it
builds.

> ?? * use macros appropriately and consistently

Usage is consistent to other packages that have been approved.

> ?? * consider using cp -p to preserve timestamps

It's used e.g. in line 98:
cp -pr build/docs/api/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}

> ?? * file permissions should be okay; %defattrs should be present

defattrs present (see lines 110, 115):
%defattr(-,root,root)

> ?? * %clean should be present

Present (see lines 78/79):
%clean
rm -rf $RPM_BUILD_ROOT

> ?? * verify the final provides and requires of the binary RPMs
> ?? * run rpmlint on the binary RPMs
> ?? * package should build on i386
> ?? * package should build in mock

See comment above about setting up mock.

FWIW, here's the provides, requires, and rpmlint for the binary rpm:

$ rpm -qp servletapi4-4.0.4-1.fc7.noarch.rpm --provides
servlet  
servlet23  
servlet4  
servletapi4 = 0:4.0.4-1.fc7

$ rpm -qp servletapi4-4.0.4-1.fc7.noarch.rpm --requires
/bin/sh  
/bin/sh  
/usr/sbin/update-alternatives  
/usr/sbin/update-alternatives  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

$ rpmlint servletapi4-4.0.4-1.fc7.noarch.rpm
W: servletapi4 non-standard-group Internet/WWW/Dynamic Content


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.