[Bug 234861] Review Request: perl-Mail-Transport-Dbx - Parse Outlook Express mailboxe

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Mail-Transport-Dbx - Parse Outlook Express mailboxe


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234861





------- Additional Comments From panemade at gmail.com  2007-04-05 02:16 EST -------
(In reply to comment #4)
> Parag, I don't understand what you don't understand:
> 
> Your log shows this:
> 
> t/0_pod.............skipped
>         all skipped: Test::Pod not installed
> t/0_pod_coverage....skipped
>         all skipped: Test::Pod::Coverage not installed
> 
> This means, the tests have not been fully excercised, because some optional
> modules were missing when building. 
> 
> Note: These modules are optional. 
  So after we create SPEC for any new perl package, we need to run "make test"
to its maximum to check for whether we are missing any optional modules for this
package or not and if we are missing anything then add those required packages
as BR to SPEC.
  
> 
> So far, it has been our policy to "test to the maximum, when possible" (In
> practice, inside of the buildsys, i.e. everything but network access or some
> cases of database access)
> 
> I.e. to let the testsuite excercise these checks, you'd have to BR: these tests'
> infrastructure.

 Ok. So this is main thing I should remember for reviewing now any perl-* packages.

> 
> > Really wonder about perl packages that make will 
> > not require or asks those BRs but make tests asks about that.
> I don't fully understand what you are trying to say, the principle of most perl
> modules' testsuites (and most testsuites in general), is to run
> "non-interactive, non-supervised" and only warn about those cases when something
> is missing.
> 
> I.e. if you want larger test coverage but some "minimal tests", you'll have to
> configure a testsuite and your system in advance to running it. In case of a
> perl module, these BR: ... means to "taylor the system for the testsuite" in
> advance to running a testsuite.


  What my basic question is towards perl-* packages/its packaging is that in
most of normal packages that uses gcc compilation uses ./configure and from
there also we can know if we are missing to add any packages as BRs. But I am
not able to find same for perl packages. Instead I saw "make test" is the only
one way to satisfy package's all requires Build time dependencies.

Now I got that. thanks for your reply.

Tom, 
 Either you can submit a new package to review again or you can add those BRs at
a time of package importing in CVS.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.