[Bug 226224] Merge Review: pam_ccreds

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pam_ccreds


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226224





------- Additional Comments From tmraz at redhat.com  2007-04-05 07:04 EST -------
(In reply to comment #1)
> W: pam_ccreds no-url-tag
Fixed.
> E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/ccreds_validate
> ['/lib/security']
> E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/cc_dump ['/lib/security']
> E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/cc_test ['/lib/security']
> -> replace rpath if possible
No, the rpath is correct because the binaries have to link to the pam_ccreds.so
module directly.

> E: pam_ccreds setuid-binary /usr/sbin/ccreds_validate root 04755
> E: pam_ccreds non-standard-executable-perm /usr/sbin/ccreds_validate 04755
> -> I think they are needed for functionality of pam_ccred
Yes.

> W: pam_ccreds buildprereq-use automake db4-devel openssl-devel pam-devel
> -> Use plain BuildRequires instead.
Fixed.

> Missing dist tag.
Added.

> Missing post, pre part with ldconfig for shared library.
There is only pam module, no regular shared library -> no need for ldconfig.

> Requires should include version, which is needed for install/build
> %{name} >= %{version}-%{release}
It should build fine with versions which are not years old I don't think
explicit versions are required.

(pam_ccreds-4-2.fc7)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.