[Bug 225253] Merge Review: apr

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: apr


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225253


jorton at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED




------- Additional Comments From jorton at redhat.com  2007-04-05 12:16 EST -------
Thanks for the review!  Please see apr-1.2.8-6 in CVS/Raw Hide.

> 1. Build root should be one of the recommended build roots:

The buildroot used meets the mandatory requirements.

> 2. The %{?dist} tag should be used in Release:

This is not mandatory.
 
> 3. BuildPrereq should not be used, use BuildRequires instead

Fixed.

> 4. Conflicts: is used and should not be.  Perhaps change Conflicts: to

The Conflicts was correct but really no longer necessary; dropped as suggested.

> 5. There are outstanding bugs for apr please address them.

This is not relevant to the packaging review process.

> 6. In %configure it should not be necessary to set CC and CXX.  If the
>    are required to be set, use %{__cc} and %{__cxx} instead of gcc and
>    g++

This is a left-over from some old build/libtool issue; dropped.

> 7. Source0: should be the upstream source location. Possibly,

Fixed.

> 8. .a files should be in a separate %{name}-static package or removed.

Removed.

> 9. rpmlint output

Fixed.

> 10. missed a .la file in apr-devel.  This should be removed

This is part of the build interface and cannot be removed.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.