[Bug 233848] Review Request: perl-SVG-Graph - Visualize your data in Scalable Vector Graphics (SVG) format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVG-Graph - Visualize your data in Scalable Vector Graphics (SVG) format
Alias: perl-SVG-Graph

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233848





------- Additional Comments From cweyl at alumni.drew.edu  2007-04-07 12:48 EST -------
The package appears to be missing a BR on perl(Statistics::Descriptive).
Also, there appears to be an examples directory (eg/), why not include it in
%doc? :)  (Note to keep rpmlint quiet you'll need to remove the exec bit from
the examples.)

Make the two above changes and I'll approve.

+ source files match upstream:
3fbf3ae9aa6ea33fd548e63dd926ee2b  SVG-Graph-0.01.tar.gz
3fbf3ae9aa6ea33fd548e63dd926ee2b  ../SVG-Graph-0.01.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. (Artistic) License text not included upstream.
+ latest version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ no debuginfo package -- noarch
+ rpmlint is silent.
+ final provides and requires are sane:
** perl-SVG-Graph-0.01-3.fc6.noarch.rpm
== rpmlint
== provides
perl(SVG::Graph) = 0.01
perl(SVG::Graph::Data)  
perl(SVG::Graph::Data::Datum)  
perl(SVG::Graph::Data::Node)  
perl(SVG::Graph::Data::Tree)  
perl(SVG::Graph::File)  
perl(SVG::Graph::Frame)  
perl(SVG::Graph::Glyph)  
perl(SVG::Graph::Glyph::axis)  
perl(SVG::Graph::Glyph::bar)  
perl(SVG::Graph::Glyph::barflex)  
perl(SVG::Graph::Glyph::bezier)  
perl(SVG::Graph::Glyph::bubble)  
perl(SVG::Graph::Glyph::heatmap)  
perl(SVG::Graph::Glyph::line)  
perl(SVG::Graph::Glyph::pictogram)  
perl(SVG::Graph::Glyph::scatter)  
perl(SVG::Graph::Glyph::tree)  
perl(SVG::Graph::Glyph::wedge)  
perl(SVG::Graph::Group)  
perl-SVG-Graph = 0.01-3.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)  
perl(Data::Dumper)  
perl(Math::Spline)  
perl(SVG)  
perl(SVG::Graph::Data::Node)  
perl(SVG::Graph::Frame)  
perl(Statistics::Descriptive)  
perl(Tree::DAG_Node)  
perl(base)  
perl(constant)  
perl(strict)  
+ %check is present and all tests pass (though not without a lot of noise):
All tests successful.
Files=7, Tests=69,  1 wallclock secs ( 0.66 cusr +  0.19 csys =  0.85 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.