[Bug 199905] Review Request: gotmail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gotmail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199905





------- Additional Comments From wolfy at nobugconsulting.ro  2007-04-07 21:10 EST -------
I appologize for not being more clear. It is customary for a reporter to help
the potential reviewers by providing the URLs for the spec and for the source
rpm under review. I was unable to locate/download either of these. Also, James,
please note that a source rpm is _mandatory_ as it has to be made public in the
fedora repositories. You could even store it at sf.net if you need to, alongside
with the tar.bz2.

I suggest replacing http://dl.sf.net with http://downloads.sourceforge.net. It
has been proved to be more reliable.

After running rpmbuild -ta over the tar.bz2, rpmlint is not happy about the
resulting src.rpm:
W: gotmail strange-permission gotmail.spec 0600
W: gotmail setup-not-quiet
W: gotmail mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 30)
First one was already discussed above; second one can be silenced by adding -q
to %setup; last one is triggered by usage of spaces in the first lines of the
spec, but tabs in the second to fifth lines of make install. It would be nice to
fix all these.

Since the wiki recommends preserving time stamps, I suggest keeping the
timestamp of the man page, especially since the %make step does nothing but
concat (and gzip) together the manual page and the AUTHORS file. A simple "touch
-r" before and after running make will fix this.
Also, using INSTALL="install -p" would probably preserve the timestamp of the
gotmail perl script (which does not happen now).
As an additional suggestion, it would be nice to remove the extra end of lines
from the end of the man page before doing the cat and add comas to the end of
each line in AUTHORS, as this will improve the aspect of the final man page.
With the current way of generating the page, under the 'Authors" section we get
an explanation about who wrote the manual, two empty lines and after that a very
long list of names without any separators between them, without an obvious link
to the previous paragraph (except of the title of the section ) and without a verb.

Despite a sponsor being required, here is a pre-review, in order to push things
a bit forward. Please mind that my hotmail account was canceled a couple of
years ago for not using it no-idea-for-how long and I have no plans to create
another one, so we will need a tester to validate that the script really works
and that the Requires: are correct. According to the docs included, curl is the
only separate package required. All other requirements seem to be picked by rpm
at build time. However I think that this aspect should be tested, too.


GOOD
- rpmlint checks : see above for source rpm; no output for the binary rpm
- package meets naming guidelines; However the first comments refer to Epoch=1;
as far as I can see, this has disappeared from this version and I am perfectly
happy so, but is Epoch=0 really intended, given comments #14 to #16?
- package meets packaging guidelines
- license (GPL ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (see above comments about the src.rpm not being
supplied), sha1sum:
adae68b51f8866eef5670f9f257d34675315d307  gotmail-0.8.9-1.tar.bz2
- the package actually bundles a Perl script included as such in the final rpm,
so no compiling involved; the make step only creates a man page
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of foreign
files/dirs
- no duplicate files
- permissions ok (modulo the spec file!)
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- not a GUI, so no need for .desktop file 
- no static, .pc, .la files
- no scriptlets needed


SHOULD
- builds in mock/devel/x86_64
- does not segfault when run without any arguments and a valid config file.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.