[Bug 229154] Review Request: konwert - Converter of character encodings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: konwert - Converter of character encodings


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229154





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-08 01:35 EST -------
Created an attachment (id=151926)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151926&action=view)
-11 spec file (some fixes added)

Well, as this is a NEEDSPONSOR ticket, I do a full review
for this package.

For -10:
* Timestamps
  - Well, actually 'INSTALL="install -p"' in %install stage does nothing, as
    all files installed in "INSTALL" macro are modified beforhand
    during the build stage.

    However, there are many files under %{_datadir}/%{name},
    of which the timestamps should
    be kept as they are not modified during build stage. This should
    be done by modifying Makefile directly.

* Lang file
  - All _documentation_ other than in English should be marked as
    %%lang(...).


The spec file attached should fix all the issues I mentioned above.
Please this the attached. If you agree with my spec file, I can
say okay for this package.

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora Extras package review requests which are waiting for someone to
review can be checked on:
https://bugzilla.redhat.com/bugzilla/buglist.cgi?cmdtype=runnamed&namedcmd=mtasaka-review-noone

NOTE: FE-NEW blockers are now not complete.

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.