[Bug 228186] Review Request: gsm - Shared libraries for GSM speech compressor
bugzilla at redhat.com
bugzilla at redhat.com
Sun Apr 8 12:04:53 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gsm - Shared libraries for GSM speech compressor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228186
bugzilla at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |medium
------- Additional Comments From bugs.michael at gmx.net 2007-04-08 08:04 EST -------
"sox" in Core is built --with-gsm and contains a copy of gsm
"linphone" in Extras contains a copy of gsm-1.0.10
[...]
@ John:
* Files in gsm-devel are not writable by owner. chmod u+w needed
* Static library should be deleted from -devel, summary and
description.
* The patch is out-of-date and needs an update. It creates
libgsm.so.1.0.10 but this is libgsm.so.1.0.12.
Suggest you add a %check section that makes sure this doesn't
happen for future patch-levels.
--- gsm.spec.orig 2007-02-11 04:46:37.000000000 +0100
+++ gsm.spec 2007-04-08 14:06:13.000000000 +0200
@@ -45,6 +45,9 @@
%{__ln_s} -f toast %{buildroot}%{_bindir}/untoast
%{__ln_s} -f toast %{buildroot}%{_bindir}/tcat
+%check
+[ -f %{_libdir}/libgsm.so.%{version} ]
+
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
* The %install section uses a few hardcoded paths that should be
replaced with macros.
* %mandir in %files section is %doc automatically.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list