[Bug 235637] Review Request: smstools - Send and receive short messages through GSM modems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smstools - Send and receive short messages through GSM modems


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235637





------- Additional Comments From ville.skytta at iki.fi  2007-04-08 15:31 EST -------
Initial review, full one later (+ assignment to myself, in the meanwhile, others
feel free to chime in) if I can get this to work with hardware I have around:

(In reply to comment #0)
> These errors should be ignored as the access restrictions are used to prevent 
> unauthorized access to the spool-dirs.

* Um, "conffile-without-noreplace-flag /etc/logrotate.d/smstools" doesn't quite 
  fall into this category, should be fixed.

* Build fails if _smp_mflags is unset, a fix is not to use the toplevel Makefile
but to do explicit "make -C src ..."

* Init script (and logrotate file) would be better called "smsd", as that's what
it starts.

* Init script exit code on usage error is not LSB compliant, should be 2.  See
/usr/share/rpmdevtools/template.init for other related cleanup and action alias
suggestions.

* smsd.conf contains very environment and hardware dependent settings, perhaps
it would be a better idea to ship a very dummy one containing just a comment or
two about where to find examples and further info, and preferably make the
service startup fail with a descriptive message (see eg. the vdr package).  The
currently installed one is not an appropriate default IMO, two GSM modems
hardcoded to specific serial ports with hardcoded init AT commands etc.

* Many docs and examples (and even the default config) contain hardcoded
/usr/local paths, should be fixed to reflect actual installed locations.

* Would be better to run as a dedicated low privileged user than root, doesn't
look like that would be hard to implement.  Device permissions would be the
hardest part, IMO a quick doc about setting them for the devices in use would be
good enough.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.