[Bug 199905] Review Request: gotmail

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 10 14:46:25 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gotmail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199905





------- Additional Comments From wolfy at nobugconsulting.ro  2007-04-10 10:46 EST -------
This time it is plain wrong. You try to set gotmail as user, which is certain to
fail everywhere since that user does not exist:

rpmlint of gotmail:
W: gotmail incoherent-version-in-changelog 0.9.0-0 1:0.9.0-0
-> this comes from the Epoch=1; the full version (e-v-r) should be included in
the %changelog entries

E: gotmail non-standard-uid /usr/share/doc/gotmail-0.9.0/COPYING gotmail
E: gotmail non-standard-gid /usr/share/doc/gotmail-0.9.0/COPYING gotmail
E: gotmail non-standard-uid /usr/share/man/man1/gotmail.1.gz gotmail
E: gotmail non-standard-gid /usr/share/man/man1/gotmail.1.gz gotmail
E: gotmail non-standard-uid /usr/share/doc/gotmail-0.9.0/ChangeLog gotmail
E: gotmail non-standard-gid /usr/share/doc/gotmail-0.9.0/ChangeLog gotmail
E: gotmail non-standard-uid /usr/bin/gotmail gotmail
E: gotmail non-standard-gid /usr/bin/gotmail gotmail
E: gotmail non-standard-uid /usr/share/doc/gotmail-0.9.0/README gotmail
E: gotmail non-standard-gid /usr/share/doc/gotmail-0.9.0/README gotmail
E: gotmail non-standard-uid /usr/share/doc/gotmail-0.9.0/sample.gotmailrc gotmail
E: gotmail non-standard-gid /usr/share/doc/gotmail-0.9.0/sample.gotmailrc gotmail
E: gotmail non-standard-uid /usr/share/doc/gotmail-0.9.0 gotmail
E: gotmail non-standard-gid /usr/share/doc/gotmail-0.9.0 gotmail
E: gotmail non-standard-uid /usr/share/doc/gotmail-0.9.0/gotmail4evolution gotmail
E: gotmail non-standard-gid /usr/share/doc/gotmail-0.9.0/gotmail4evolution gotmail

 Pretty please, stop trying to work around packaging bugs and read a bit about
preserving the modes. The umask=022 is not needed, the (-,root,root,-) was fine... 
 All you have to do is
- work as an regular user (not root)
- ensure umask is 022
- chmod all files which have to be included to 0644 (minus the executable which
should be 0755, of course)
- create a tarball where all the included stuff is chmod-ed as above
- rpmbuild -bs (or -bt) using the correctly created spec (or tarball)

By the way, if you remove the exec bit from gotmail4evolution you'll avoid later
warnings from rpmlint (this script -- which is a %doc -- because it has the
executable bit set, will pull bash as a dependency; generally it is considered
bad habit to have %doc bring in deps; in this particular case I would accept
this, because bash is present already on any fedora system but as I said this is
a very bad habit that you should avoid) [*]
Also, please increase the release each time you modify something and (in the
future) start counting the release from 1.

[*] this problem seems to be fixed in the package listed at comment #43 but I am
not sure at this point that you actually intendted it or it was just an unwanted
side effect of the other modifications.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list