[Bug 199905] Review Request: gotmail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gotmail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199905





------- Additional Comments From wolfy at nobugconsulting.ro  2007-04-10 13:18 EST -------
Excellent, James, all problems but one seem to be fixed now.

There is one issue which must be fixed before having the package accepted:
Source gotmail-0.9.0.tar.bz2 is different from upstream
Given the fact that you are the upstream maintainer, the large number of changes
which have occured during these last days and the fact that all files are hosted
on SF servers, it might be that not all the servers have synced with the new
version (see? that's why it's a good idea to not touch the tarball and to
increment the release when you do...). Just to be sure, please verify that the
tar.bz2 included in the src.rpm and the standalone one are identical.
The other issue that might be discussed is that, given the script's ability to
forward the messages to SA and procmail, it might be a good idea to Require:
these two. Because these two are "soft requires", I for one am happy with it
such as it is now, leaving the option to install or not the other two packages
to the user.


So: from my point of view and assuming the script works as advertised (I assume
it does since the perl script has not been modified in 3 months, but as I said I
don't have a hotmail account and I have no intent to create one), the package is
ready for approval. You now have to convince a sponsor.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.