[Bug 226134] Merge Review: mdadm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mdadm


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226134


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?,
                   |                            |needinfo?(dledford at redhat.co
                   |                            |m)




------- Additional Comments From wolfy at nobugconsulting.ro  2007-04-11 07:38 EST -------
Quick pre-review of release 2.6.1-2.fc7
* RPM name is OK
* Source mdadm-2.6.1.tgz is the same as upstream
* This is the latest version
* Builds fine in mock
* License GPL, is OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)  (wiki: Packaging/Guidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: Packaging/Guidelines#parallelmake)
* Spec file: there is a "/sbin" in make install which should be replaced with
RPM macros (%_sbindir) (wiki: Packaging/Guidelines#macros)
* The BuildRoot must be cleaned at the beginning of %install
* make install (static ?) -- compiles stuff but does not use rpm_opt_flags; why
is it not compiled in %build ?
* Timestamps are not preserved for man pages, mdadm.conf-example and
init.d/mdmonitor (you should probably use install -p)
* Missing dependancies on chkconfig and service for %post / %preun / %postun
* mdadm service is enabled by default in /etc/rc.d/init.d/mdmonitor. Fedora
policy recommends services to be off by default and allow the admin to enable
them at will
* Most of the ANNOUNCE files could be dropped. The useful information is
available in the Changelog file
* In %Changelog, the line with 2.5.0-6 (which should have been 1.5.0-6) contains
an unescaped macro (%postun)
* Should require /usr/sbin/sendmail or maybe MTA, not smtpdaemon. See also
DSendmail="/usr/sbin/sendmail -t" in the Makefile

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.