[Bug 221906] Review Request: gmediaserver - UPnP compatible media server for the GNU system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gmediaserver - UPnP compatible media server for the GNU system
Alias: gmediaserver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221906





------- Additional Comments From bjohnson at symetrix.com  2007-04-11 15:43 EST -------
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Rpmlint output:
       E: gmediaserver non-standard-uid /srv/gmediaserver gmediaserver
       E: gmediaserver non-standard-gid /srv/gmediaserver gmediaserver
       E: gmediaserver non-standard-uid /var/log/gmediaserver/gmediaserver.log
gmediaserver
       E: gmediaserver non-standard-gid /var/log/gmediaserver/gmediaserver.log
gmediaserver
       E: gmediaserver non-standard-uid /var/log/gmediaserver gmediaserver
       E: gmediaserver non-standard-gid /var/log/gmediaserver gmediaserver

      These are acceptable as the package will own the log and media directories.
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must matches the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the  Packaging Guidelines.
 [x] Package is licensed with an open-source compatible license and meet other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is written in American English.
 [x] Spec file for the package is legible.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     MD5SUM this package    : 7f99a9b2e32c41acf7e71eb0bc0840e9
     MD5SUM upstream package: 7f99a9b2e32c41acf7e71eb0bc0840e9
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: FC6/i386
 [x] Package is not known to require ExcludeArch, OR:
     Arches excluded:
     Why:
 [!] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
     Build is not picking up the uuid libraries.  These are not the ossp-uuid
libraries that you added to the BR, but the e2fsprogs uuid libraries.  Please
remove uuid-devel from the BR and add e2pfsprogs-devel.  BR also does not
contain pkgconfig which is required for the uuid detection.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package is not relocatable.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: FC6/i386
 [-] Package should compile and build into binary rpms on all supported
architectures.
     Tested on:
 [?] Package functions as described.
     Unable to test as I don't have any upnp devices.
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [x] File based requires are sane.
 [x] Latest version is packaged.

=== Issues ===
1.  Package source file timestamp does not match upstream.  Consider downloading
with "wget -N".
2.  Missing/incorrect BR noted above.
3.  init file line wraps on line 4-5, please pick a better break point
4.  init file / LSB info requires $syslog - not needed since it does not use syslog

=== Final Notes ===
1.  I was only able to start/stop program and verify that it did run.  I don't
have a upnp media device to test with.  I also noted that there was no
information sent to the log files.  If this seems to be a problem, please look
into it.


Go ahead and fix this up and I'll approve the package.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.