[Bug 225730] Merge Review: eog

bugzilla at redhat.com bugzilla at redhat.com
Sat Apr 14 17:30:52 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eog


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225730


dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From dakingun at gmail.com  2007-04-14 13:30 EST -------
GOOD:
* Package name conforms to the Fedora Naming Guidelines
* Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* No file duplicates
* Package builds OK in Mock.
* Source matches upstream
md5sum: 32f4cd4cd3108522eccf0b8fd85c8bbd  eog-2.18.0.1.tar.bz2

rpmlint warnings (no so serious);
$ rpmlint eog-2.18.0.1-2.fc7.src.rpm
W: eog mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 78)
$ rpmlint eog-2.18.0.1-2.fc7.x86_64.rpm
W: eog non-conffile-in-etc /etc/gconf/schemas/eog.schemas

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list