[Bug 236537] Review Request: gpsbabel - A tool to convert between various formats used by GPS devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gpsbabel - A tool to convert between various formats used by GPS devices


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236537


sander at hoentjen.eu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From sander at hoentjen.eu  2007-04-16 08:12 EST -------
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPL ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Suggestion:
You can include gpsbabel-sample.ini in the %doc section, to provide an example
for people to use, but this is up to you.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.