[Bug 235763] Review Request: windowlab - Small and Simple Amiga-like Window Manager

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 16 12:29:30 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: windowlab - Small and Simple Amiga-like Window Manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235763


alexl at users.sourceforge.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexl at users.sourceforge.net




------- Additional Comments From alexl at users.sourceforge.net  2007-04-16 08:29 EST -------
I also can't sponsor, but I'll make some notes rather than a formal review:

1) Builds cleanly in mock
2) rpmlint is silent on RPM and SRPM
3) Package doesn't respect RPM_OPT_FLAGS, see:

http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448

+ make
gcc -g -O2 -Wall -W -DSHAPE
-DDEF_MENURC="\"/etc/X11/windowlab/windowlab.menurc\"" -I/usr/include  -c main.c
-o m
ain.o
gcc -g -O2 -Wall -W -DSHAPE
-DDEF_MENURC="\"/etc/X11/windowlab/windowlab.menurc\"" -I/usr/include  -c
events.c -o
 events.o


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list