[Bug 234826] Review Request: FlightGear - Flight Simulator

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 16 15:39:42 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FlightGear - Flight Simulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234826





------- Additional Comments From fabrice at bellet.info  2007-04-16 11:39 EST -------
(In reply to comment #7)

Thanks for the review Bernard,

> === Issues ===
> 1. Possible missing BR, from build.log:
>    "checking for library containing hid_init... no"

hid_init() from libusbhid is specific to freebsd (from configure.ac):
dnl add joystick support libraries
dnl search for FreeBSD library
AC_SEARCH_LIBS(hid_init, usbhid)
joystick_LIBS="$LIBS"
LIBS=""

so IMO, it's safe to ignore this unsatisfied check (joystick interface should be
handled by plib IIRC)

>    "checking for X... no"

Checking for X (in fact looking for XIntrisic.h from libXt-devel) comes from the
AC_PATH_XTRA macro, that defines X_DISPLAY_MISSING in src/Include/config.h. This
macro is used nowhere in the source code and in the included headers. My
conclusion is that adding libXt-devel to the buildroot has no consequence on the
build result.

> 2. Host listed in Source0 URL appears to be down.  Please verify if this is
> still a valid download link.

yes, I confirm that ftp.flightgear.org is currently unreachable. This is
probably a transcient problem, as it appears on
http://www.flightgear.org/mirrors.html#ftp at the first row and its dns name
indicates that its probably the primary/master mirror.

> 3. Please clean up %doc entries that are related to building, installation, or
> other operating systems.

done.

> 4. Please change "%patch0 -p1" to "%patch0 -p1 -b .no-automake-in-configure"

done.

> 5. What is the reason to add -fPIC to $RPM_OPT_FLAGS?  If this is truly needed,
> it must be documented.

This option is not needed, it's a mistake. I removed it from the spec file.
 
> 6. Please change "%defattr(-, root, root, 0755)" to "%defattr(-, root, root, -)
> and if needed, fix install section to set correct permissions.

done

> 7. Must include a .desktop file (please see
> http://fedoraproject.org/wiki/Packaging/Guidelines#desktop)

Done. I added a .desktop file, but I didn't find a suitable icon, neither in the
 source tarball, nor in the fgfs-base package. Is it acceptable to ship a
desktop file without icon ? 

New SPEC: http://fr2.rpmfind.net/pub/bellet/review/FlightGear.spec
New SRPM: http://fr2.rpmfind.net/pub/bellet/review/FlightGear-0.9.10-5.fc6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list