[Bug 235588] Review Request: escape - an extensible puzzle game
bugzilla at redhat.com
bugzilla at redhat.com
Mon Apr 16 15:42:26 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: escape - an extensible puzzle game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235588
------- Additional Comments From limb at jcomserv.net 2007-04-16 11:42 EST -------
Ok, let's see.
rpmlint -i clean, except for debuginfo, which complains that several source
files are marked executable. Might want to submit to upstream, but not a
showstopper IMHO:
W: escape-debuginfo spurious-executable-perm /usr/src/debug/escape-src/dirt.h
W: escape-debuginfo spurious-executable-perm /usr/src/debug/escape-src/sound.h
E: escape-debuginfo script-without-shebang /usr/src/debug/escape-src/dirt.cpp
E: escape-debuginfo script-without-shebang /usr/src/debug/escape-src/sound.cpp
W: escape-debuginfo spurious-executable-perm /usr/src/debug/escape-src/progress.h
W: escape-debuginfo spurious-executable-perm /usr/src/debug/escape-src/sound_enum.h
E: escape-debuginfo script-without-shebang /usr/src/debug/escape-src/progress.cpp
Good package/spec names.
Meets packaging guidelines.
License OK.
Spec is legible American English.
[limb at fawkes fedora]$ md5sum escape-src-200704130.tar.bz2
07263976a54607792dbbe4bc442f0735 escape-src-200704130.tar.bz2
[limb at fawkes fedora]$ md5sum /usr/src/redhat/SOURCES/escape-src-200704130.tar.bz2
1764ef8aad634e6f71c5533fc7eafe21
/usr/src/redhat/SOURCES/escape-src-200704130.tar.bz2
ISSUE: MD5 mismatch. Put the tarball from upstream straight in the SRPM, no
modification.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list