[Bug 225925] Merge Review: jakarta-commons-dbcp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: jakarta-commons-dbcp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225925





------- Additional Comments From mwringe at redhat.com  2007-04-16 16:47 EST -------
(In reply to comment #10)
> Good:
> + Naming seems ok.
> + Package contains license text.
> + Mock build works fine.
> 
> 
> Bad:
> - Source0 contains not a full qualified URL
Fixed
> - Bad Buildroot
> BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Fixed
>   (wiki: PackagingGuidelines#BuildRoot)
> 

New srpm here:
https://mwringe.108.redhat.com/files/documents/175/323/jakarta-commons-dbcp-1.2.1-10jpp.1.fc7.src.rpm

(sorry for the delay, I kindof lost track of this one)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.