[Bug 225938] Merge Review: jakarta-taglibs-standard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: jakarta-taglibs-standard


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225938





------- Additional Comments From pcheung at redhat.com  2007-04-16 23:47 EST -------

(In reply to comment #3)
> (In reply to comment #2)
> 
> > X verify source and patches (md5sum matches upstream, know what the patches do)
> >  - if upstream doesn't release source drops, put *clear* instructions on
> >    how to generate the the source drop; ie.
> >   # svn export blah/tag blah
> >   # tar cjf blah-version-src.tar.bz2 blah
> > I can only find 1.1.2 src tar ball on the mentioned site for Source0
> Fixed. This is due to apache having one location for the lastest packages and
> another for older packages (archives). I have switched the link to point to the
> archives section as this pacakges is no longer the most current.
md5sum now matches.

> 
> > X correct buildroot
> >  - should be:
> >    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> > Please fix buildroot
> Fixed
Great!
> 
> > X specfile is legible
> >  - what is the difference between jversion and version? (since both is 1.1.1, do
> >   we need both?)
> good point, I have no idea why jversion is in there. It has been removed.
> 
Thanks.

Please get rid of the section tag.

Forgot to mark an X besides this:
* skim the summary and description for typos, etc.
 -  description says 'This directory contains releases for the 1.1.x ...',
    should it be 'This package .... for the 1.1.1 ...'?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.