[Bug 226387] Merge Review: samba

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: samba


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226387


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium




------- Additional Comments From ssorce at redhat.com  2007-04-19 10:44 EST -------
(In reply to comment #30)
> Still pending remarks:
> 
> - Does "/usr/lib* instead of %{_libdir}" hack still needed for the latest
> upstream versions?

I am trying to change it to %{_libdir}, let's see what happens.

> - docs/manpages contain non-ascii non-UTF8 symbols (yet not checked out for
> 3.0.25 :) ). Non-UTF8 is deprecated now.
> (BTW, run f.e. "man smbd" and see the man's warning in the first 3 lines).

This is an upstream problem, trying to fix it there.

> - Init scripts: /etc/rc.d/init.d/finctions existance is checked "hardly",
> whereas /etc/sysconfig/network is not... Since the init scripts are separate
> sources for Fedora, it can be fixed easily.

Ok, fixind this.

> - winbind.init: /var/lock/subsys name should match the initscript name, i.e.
> should be "/var/lock/subsys/winbind", not ".../winbindd" (rmplint complains
> about it).

Sorry but I can change the subsystem file name in the lock dir or upgrades would
fail to condrestart. Or I would have to check for both which is not pretty.

But you made me see that we don't start winbindd if networking is set to no.
With the winbindd offline mode, I think we may want to start it anyway.

Thougths about this?

> Since "/var/cache/samba" is no more used, maybe create a symlink to
> /var/lib/samba? (at least "for compatibility reasons" :) ) Perhaps this way
> (old and new places are playing together) the migration procedure could be
> simplified...

No, the migration would just break, as the script will find stuff in
/var/cache/samba and in /var/lib/samba, it will move the stuff in /var/lib/samba
to a backup and try to move /var/cache/samba to /var/lib/samba.
But as we moved away that stuff to backup it, the script will fail finiding
anything in /var/cache/samba and as result we just break new installtion by
leaving them without files in the real /var/lib/samba

Besides I want to see the absence of a /var/cache/samba directory as a mark we
have upgraded.

Simo.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.