[Bug 226230] Merge Review: parted

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: parted


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226230


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

dcantrell at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(dcantrell at redhat.c|
                   |om)                         |




------- Additional Comments From dcantrell at redhat.com  2007-04-19 14:52 EST -------
(In reply to comment #1)
>  [!] Rpmlint output:
> #rpmlint parted-1.8.6-4.src.rpm
> W: parted no-url-tag
>  rpmlint ~/reports/parted/parted-1.8.6-4.fc7.x86_64.rpm
> W: parted no-url-tag
> --> an URL tag should be provided

Fixed.

>  [!] Duplicate BR: automake (by libtool), libsepol-devel (by libselinux-devel)

Fixed.

>  [!] Package does not contain duplicates in %files.

Fixed.

>  [!] Package requires pkgconfig, if .pc files are present.

Fixed.

> 1. Summary ends with dot. As far as I remember (rpmlint does not say anything,
> and it is latest version) it was preffered to not end sumaries with dot. Not a
> big deal.

Fixed.

> 2. parted-devel should require pkconfig. MUSTFIX

Fixed.

> 3. there is a texinfo file (doc/parted-pt_BR) which might be shipped but is not.

Don't think this file is correct anymore, so that's why it isn't installed. 
Will check on that.

> 4. %files has a duplicate line: %{_libdir}/libparted-*.so.* is included twice.
> MUSTFIX

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.