[Bug 235189] Review Request: nautilus-python - Python bindings for Nautilus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nautilus-python - Python bindings for Nautilus


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189


jspaleta at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jspaleta at gmail.com
               Flag|                            |fedora-review?




------- Additional Comments From jspaleta at gmail.com  2007-04-20 04:15 EST -------
The Good
+ naming is good
+ specfile name matches base package name 
+ Licensed as GPL and includes COPYING file accordingly
+ specfile written in english-ese and is legible
+ included source md5sum checks with upstream source as listed in SOURCE0 url
f4bd5de3a9e01c80fc0a2ef7aeb64dd7  nautilus-python-0.4.3.tar.gz
+ builds on x86 fedora-development in mock
+ buildrequires look good
+ no locales
+ not relocatable
+ base package owns all directories it creates and directory ownership of parent
directories is accounted for in package deps
+ permissions seem to be okay
+ clean section is okay
+ consistent use of macros
+ permissible code and content
+ items in doc are not runtime necessary
+ devel requires versioned base package
+ not a gui
+ does not obviously own files from another package 
+ install section looks good
+ build.log shows its using the RPM_OPT_FLAGS

The Bad
- Must remove all .la files
- devel subpackage needs to require pkgconfig due to directory ownership rules
- Need to include appropriate ldconfig scriptlets for shared libraries

The Suggestions
? Would it be better if the examples were placed in docs section of the devel
package, instead of in the main package?

The Corrections
  Attached you'll find an updated spec file that corrects the blocker items
listed above. Please review it write back if you need to discuss anything. Once
you resubmit updated spec and srpm urls that correct the blockers this should be
approvable.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.