[Bug 226337] Merge Review: pyparted
bugzilla at redhat.com
bugzilla at redhat.com
Fri Apr 20 16:48:15 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: pyparted
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226337
dcantrell at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
Flag|needinfo?(dcantrell at redhat.c|
|om) |
------- Additional Comments From dcantrell at redhat.com 2007-04-20 12:48 EST -------
(In reply to comment #1)
> I am planning on reviewing this one, but I have a few questions/suggestions,
> before doing an official full review:
>
> - rpmlint has a couple of complaints on the src.rpm:
> W: pyparted no-url-tag
Fixed.
> W: pyparted mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 27)
Fixed.
> - I notice CFLAGS is explicitely set :
> export CFLAGS="-fPIC -O2 -g2"
> If there is a good reason to override the default compiler options (including
> the -fortify and so on), please be as kind as to explain it.
There is no good reason. Holdover from old old spec file. Removed.
> - SMP flags are not used; if their usage breaks compilation, please state that
> in the spec, otherwise please use them
Fixed.
> - The theory says that %makeinstall should be avoided, if possible. I assume it
> is a must in this case? If so, could you please add a comment in the spec, to
> make it clear ?
Fixed.
> - I suggest adding AUTHORS and Changelog to the list of files, so that we know
> who to bug in case of trouble :)
Fixed. Made a note in the AUTHORS file to use bugzilla.redhat.com to report bugs.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list