[Bug 235763] Review Request: windowlab - Small and Simple Amiga-like Window Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: windowlab - Small and Simple Amiga-like Window Manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235763


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tummy.com  2007-04-22 21:51 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
d566b989f8e59b169f7affa462762c17  windowlab-1.34.tar
d566b989f8e59b169f7affa462762c17  windowlab-1.34.tar.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.  
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. rpmlint says:

W: windowlab-debuginfo spurious-executable-perm
/usr/src/debug/windowlab-1.34/events.c
W: windowlab-debuginfo spurious-executable-perm
/usr/src/debug/windowlab-1.34/taskbar.c
W: windowlab-debuginfo spurious-executable-perm
/usr/src/debug/windowlab-1.34/menufile.c
W: windowlab-debuginfo spurious-executable-perm /usr/src/debug/windowlab-1.34/main.c
W: windowlab-debuginfo spurious-executable-perm
/usr/src/debug/windowlab-1.34/windowlab.h
W: windowlab-debuginfo spurious-executable-perm
/usr/src/debug/windowlab-1.34/manage.c
W: windowlab-debuginfo spurious-executable-perm /usr/src/debug/windowlab-1.34/new.c
W: windowlab-debuginfo spurious-executable-perm /usr/src/debug/windowlab-1.34/misc.c
W: windowlab-debuginfo spurious-executable-perm
/usr/src/debug/windowlab-1.34/client.c

This is pretty cosmetic, but you could 'chmod 644' those sources and/or
just mention it to the upstream that they shouldn't have executable source files
in their tar.

I don't see any blockers here, so this package is APPROVED. 

I will be happy to sponsor you. 
You can continue the process from: 
http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b

Don't forget to close this review request once this package has been imported
and built.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.