[Bug 230560] Review Request: wqy-bitmap-fonts - a fine-tuned Chinese bitmap font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wqy-bitmap-fonts - a fine-tuned Chinese bitmap font


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230560


bbbush.yuan at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ccheng at redhat.com




------- Additional Comments From bbbush.yuan at gmail.com  2007-04-23 01:59 EST -------
It seems I have to explain my idea a bit longer. :)

* bitmap fonts are always under "misc" directory.
I totally agree that the /usr/share/fonts/wenquanyi/ directory is needed. What I
mean is to use "misc" sub directory instead of %{name}. Well this issue is minor.

* The font has BDF source so why not use that as Source0, and use bdftopcf to
generate PCF on the fly.
Why not?

* Requires(pre): /usr/bin/mkfontdir
I mean xorg-x11-font-utils may not exist in older release of fedora. I'm not
familiar with X packages so could anyone confirm it?

* Why conflicts?
* Why provides? Why conflicts and provides don't not match?
I forget where I read this, that when a package conflicts another, it should
also provides that package to make the upgrade happens smoothly. Also use
Provides intead of Conflicts is better I think. 
The package don't have explicitly Provides itself.

* install -d -m755 on both %{fontdir} and %{fontconfdir}
I mean -m755 is missing from your script.
The newly added "install -d ...fontdir" is redundant.

* %defattr(-, root, root, -) is nicer
Yes, this is in the default template. (Do you use rpmdev-newspec and rpmlint?)

* %doc should not contain INSTALL*
Again I forget where I learned this.

* Keep old changelogs
I like old changelogs, especially for projects like WenQuanYi. :D

Hope CCheng could have a look at this, too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.